ref(hub): Move @sentry/hub code to @sentry/core
#5823
Conversation
timfish
changed the title
@sentry/hub code to @sentry/core
timfish
force-pushed
the
feat/move-hub
branch
from
6b15512 to
472f616
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
We merged in #5873, which prob requires a more tricky rebase. |
|
Should we be marking all |
Good idea! Let's do that. |
|
Since the exports in export { getCurrentHub as getCurrentHubCore } from '@sentry/core';
/**
* @deprecated This export has moved to @sentry/core. The @sentry/hub package will be removed in v8
*/
const getCurrentHub = getCurrentHubCore;
export { getCurrentHub } |
|
Ok, I think this is now good to go. I couldn't mark |
@timfish, since they're classes, could you do import { Hub as CoreHub } from '@sentry/core';
/**
* @deprecated This export has moved to @sentry/core. The @sentry/hub package will be removed in v8
*/
export class Hub extends CoreHub { };? |
|
It does leave me with a strange feeling that it is somehow exporting a different type to before but my logical side says that it's totally fine! 🙃 |
|
Can we move the tests in another PR? Let's try to get this released on Monday alongside the NextJS experimental flag switch |
|
Leaving the tests in hub was instrumental in ensuring that there were no breaking changes in Safe to move then now? |
Ahhh great point, then let's keep them until we do the actual deletion during the major. |
Closes #5665
This PR:
@sentry/hubcode files to@sentry/core@sentry/hubto a stub that re-exports the same types from@sentry/core@sentry/hubnow only depends on@sentry/core@sentry/hub->@sentry/core@sentry/hubas a dependency from packages@sentry/hubtests where they are for nowSurprisingly this results in a 159 byte increase in minified bundle size!
I've compared the type exports from
@sentry/hubfrom before and after this PR and the exports match so it looks like this isn't a breaking change 😬